Fix icon when passing Marker to GeoJson #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
hansthen
requested changes
Jan 25, 2025
folium/map.py
Outdated
| @@ -403,8 +403,11 @@ def __init__( | |||
| self.options = remove_empty( | |||
| draggable=draggable or None, autoPan=draggable or None, **kwargs | |||
| ) | |||
| # this attribute is not used by Marker, but by GeoJson | |||
| self.icon: Optional[Icon] = None | |||
There was a problem hiding this comment.
This still fails if people use the add_child method to add an icon. I am okay with that, but I think we should be aware of it.
There was a problem hiding this comment.
Also the render method (roughly lines 430-436) was originally rewritten to allow people to use add_child. If we go back to icon as a member variable, we should make it consistent throughout the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2084, which is an issue introduced by #2068.
We shouldn't have removed
self.iconinMarker. It's not directly visible where it is used, so I added a comment to prevent this from happening again.