Add a date_option (format string) parameter to the choropleth timeline slider #2003
Conversation
hansthen
force-pushed
the
format_time_in_chloropleth_slider
branch
from
4c13121
to
92d8456
Compare
| @@ -19,6 +19,8 @@ class TimeSliderChoropleth(JSCSSMixin, Layer): | |||
| styledict: dict | |||
| A dictionary where the keys are the geojson feature ids and the values are | |||
| dicts of `{time: style_options_dict}` | |||
| date_options: str, default "ddd MMM DD YYYY" | |||
There was a problem hiding this comment.
later on it's called date_format, why not call it that here as well?
There was a problem hiding this comment.
To be consistent with the other plugins. timestamped_geojson and timeline also use date_options. I would prefer date_format for the other plugins as well, but I don't think it is worth the effort.
| @@ -19,6 +19,8 @@ class TimeSliderChoropleth(JSCSSMixin, Layer): | |||
| styledict: dict | |||
| A dictionary where the keys are the geojson feature ids and the values are | |||
| dicts of `{time: style_options_dict}` | |||
| date_options: str, default "ddd MMM DD YYYY" | |||
| A format string to render the currently active time in the control. | |||
There was a problem hiding this comment.
should we specify what formatting language is being used here? Like, what fields like MMM DD are available?
There was a problem hiding this comment.
If you feel strongly about it, I can add a link to the formatting library used. However, I don't think it is necessary. The time string formatting language is fairly intuitive (and fairly universal). Also, I would like the documentation to be consistent between the different plugins.
Closes #1997