Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move verbose and coverage options for pytest back to ci script #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move verbose and coverage options for pytest back to ci script #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7515975
Move verbose and coverage options for pytest back to ci script
vxgmichel Jan 12, 2019
740d5fc
Merge branch 'master' into pytest-ini
CoolCat467 Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ else

# These environment variables ensure that the import of the pytest-trio plugin is covered
# even if pytest-trio is loaded before pytest-cov. See https://pytest-cov.readthedocs.io/en/latest/plugins.html
env COV_CORE_SOURCE=pytest_trio COV_CORE_CONFIG=.coveragerc COV_CORE_DATAFILE=.coverage pytest
env COV_CORE_SOURCE=pytest_trio COV_CORE_CONFIG=.coveragerc COV_CORE_DATAFILE=.coverage pytest -ra --verbose --cov

# The codecov docs recommend something like 'bash <(curl ...)' to pipe the
# script directly into bash as its being downloaded. But, the codecov
Expand Down
4 changes: 2 additions & 2 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[pytest]
addopts = -ra -v --pyargs pytest_trio --verbose --cov
addopts = -W error --pyargs pytest_trio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally like to see the --pyargs pytest_trio go away too as it keeps me from running individual tests such as when trying to debug with breakpoints in PyCharm. At which point we are left with -W error and could just move everything to CI and drop this file. I think this is where https://github.com/python-trio/trio/ itself is at.

For that matter, the --cov (that you already moved) broke breakpoints entirely in PyCharm too.

https://youtrack.jetbrains.com/issue/PY-20186

filterwarnings =
error
default::pytest.PytestAssertRewriteWarning
default::pytest.PytestDeprecationWarning
default::pytest.PytestUnraisableExceptionWarning
default::pytest.PytestUnraisableExceptionWarning
Loading