Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy==0.991 #202

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

mypy==0.991 #202

wants to merge 10 commits into from

Conversation

altendky
Copy link
Collaborator

No description provided.

@bluebird75
Copy link
Collaborator

This version of mypy is not released for Python 3.6 . So we need to add a conditional, one way or the other...

Apart from that, we can also search which was the first version that was broken by our stubs. I don't have much time right now for this, though.

@altendky
Copy link
Collaborator Author

Locally here in Linux, 0.940 is the first version to SIGSEGV. With 0.960 through 0.991 I get a few messages first but then they also SIGSEGV. python/mypy@a9c62c5 acts similar to 0.991. There are messages followed by a SIGSEGV, though there's an additional message. See python/mypy#14196.

"mypy==0.930; python_version < '3.7'",
"pytest",
"pytest-xvfb",
],
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know you can do things like this. Nice!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the env_var list at https://peps.python.org/pep-0508/.

env_var       = ('python_version' | 'python_full_version' |
                 'os_name' | 'sys_platform' | 'platform_release' |
                 'platform_system' | 'platform_version' |
                 'platform_machine' | 'platform_python_implementation' |
                 'implementation_name' | 'implementation_version' |
                 'extra' # ONLY when defined by a containing layer
                 )

Though it appears this boundary may belong closer to 0.981 python/mypy@dc118e2.

@bluebird75
Copy link
Collaborator

I am convinced that we should have a very stable mypy for our tests, and one CI job with failure allowed for testing latest mypy.

Until this is fixed, 0.930 is our good version then.

@altendky
Copy link
Collaborator Author

Dependabot style automatic PRs are an alternative to consider instead of having 'latest version' jobs. But, there are upsides to all of various approaches to this.

Reported the segfault upstream. https://www.riverbankcomputing.com/pipermail/pyqt/2022-November/045068.html I'll take a look at a stubtest wrapper that monkey patches to disable the class finality test.

@altendky
Copy link
Collaborator Author

segfaults gone... now just 2853 regular stubtest errors. Hopefully my comments around the dependency versions in setup.py are sufficient to have a clue about what we're stuck on here.

@bluebird75
Copy link
Collaborator

At least it passes with Python 3.6

@altendky
Copy link
Collaborator Author

Note that there's mypy 1.0 now as well. Depending, it may be better to work this intermediate step, or may be better to just get to 1.0 directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants