-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs #1283
Update docs #1283
Conversation
|
||
$ curl --http2 https://nghttp2.org/httpbin/get | ||
|
||
To use it with our server though, you will need to invoke it with a different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use it with our server though, you will need to invoke it with a different | |
To use it with a ``python-hyper/h2``-based server, you can invoke it with a different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this context I meant to use it with the server from this example, not any arbitrary hyper/h2-based server (as generally you will serve it with TLS), so you should or you have to is probably better.
@Kriechi addressed your concerns, still have one open regarding phrasing, but otherwise should be ready for another check |
Co-authored-by: Thomas Kriechbaumer <[email protected]>
Thanks for making the changes! Looks good to me overall. Seems the docs building with sphinx broke - likely unrelated to this PR though... I'll look into it in the next days, unless you beat me too it 😄 |
@Kriechi fixed |
Thanks! 🎉 |
Changes
curl
usage examples with http2openssl
certificate generation commandreadlines
methodsasync
/await
syntax