Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streams: Prevent RST_STREAM from being sent multiple times #1267

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

streams: Prevent RST_STREAM from being sent multiple times #1267

wants to merge 3 commits into from
+184 −93

Commits on Mar 28, 2022

  1. tests: Fix RST_STREAM asserts not conforming to RFC

    @MadMockers
    MadMockers committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    6a03e70 View commit details
    Browse the repository at this point in the history

  2. streams: Prevent RST_STREAM from being sent multiple times 

    Previously, RST_STREAM would be sent even when the stream closed by
state was in SEND_RST_STREAM. This fix instead checks which peer
closed the stream initially, and then updates the closed by value
from RECV_RST_STREAM to SEND_RST_STREAM after a RST_STREAM frame
has been sent on a previously reset stream.

Streams that have a closed by value of SEND_RST_STREAM now ignore
all frames.
    @MadMockers
    MadMockers committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    ec52beb View commit details
    Browse the repository at this point in the history

  3. tests: Add coverage to RST_STREAM fixes

    @MadMockers
    MadMockers committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a1991c7 View commit details
    Browse the repository at this point in the history