Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag loop-remove #3018

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

GriceTurrble
Copy link

@GriceTurrble GriceTurrble commented Apr 16, 2024

Details the gotcha of removing items from a collection while iterating that collection inside a for loop.

This should add tags for !loop-remove, !loop-add, and !loop-modify, all pointing to the same embed.

@wookie184 wookie184 added t: feature New feature or request a: tests Related to tests (e.g. unit tests) s: needs review Author is waiting for someone to review and approve labels Apr 20, 2024
@vivax3794
Copy link
Member

I made a gif for this as discussed on discord, you ofc have my full permission to use it. it has a similar quality/fps to the return-gif one (actually slightly bigger).

DefaultTemplate_ManimCE_v0 18 0 post0

@Xithrius Xithrius added a: tests Related to tests (e.g. unit tests) a: tags Related to bot tags p: 3 - low Low Priority and removed a: tests Related to tests (e.g. unit tests) labels Apr 27, 2024
@mbaruh
Copy link
Member

mbaruh commented Jul 5, 2024

I made a gif for this as discussed on discord, you ofc have my full permission to use it. it has a similar quality/fps to the return-gif one (actually slightly bigger).

That's a really cool GIF. One thing is that I think it's better to show on the right what's being printed, to clarify that the result is "2\n4\n". Currently it looks like it ends too soon before I can understand what you're showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tags Related to bot tags p: 3 - low Low Priority s: needs review Author is waiting for someone to review and approve t: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants