-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tag loop-remove #3018
Open
GriceTurrble
wants to merge
13
commits into
main
Choose a base branch
from
feat/tag-list-iterate-and-remove-gotcha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: tag loop-remove #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details the gotcha of removing items from a collection while iterating that collection inside a for loop.
wookie184
reviewed
Apr 16, 2024
Co-authored-by: wookie184 <[email protected]>
wookie184
added
t: feature
New feature or request
a: tests
Related to tests (e.g. unit tests)
s: needs review
Author is waiting for someone to review and approve
labels
Apr 20, 2024
Xithrius
added
a: tests
Related to tests (e.g. unit tests)
a: tags
Related to bot tags
p: 3 - low
Low Priority
and removed
a: tests
Related to tests (e.g. unit tests)
labels
Apr 27, 2024
That's a really cool GIF. One thing is that I think it's better to show on the right what's being printed, to clarify that the result is "2\n4\n". Currently it looks like it ends too soon before I can understand what you're showing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: tags
Related to bot tags
p: 3 - low
Low Priority
s: needs review
Author is waiting for someone to review and approve
t: feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details the gotcha of removing items from a collection while iterating that collection inside a for loop.
This should add tags for
!loop-remove
,!loop-add
, and!loop-modify
, all pointing to the same embed.