Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change db pattern #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mouadhkaabachi
Copy link

I think passing client_encoding=utf8 in create_postgresql_engine() directly no a good solution, client_encoding is for postgres, so if you use mysql or any thing else..., it won"t work

@hartym
Copy link
Member

hartym commented Oct 27, 2017

I am currently wondering if it's a good idea at all to have this "create_postgresql_engine" function in bbsqla. In fact, isn't it better to just use sqlalchemy.create_engine?

Having a specific PG option in a create_POSTGRESQL_engine function does not shock me, but I'm wondering if this is not a bit out of scope for the extension, what do you think?

@hartym hartym added the backlog label Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants