Math Library for Combining Pyth Prices on Solidity #1719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holps-7 is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
|
We have decided to move forward with #1746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an implementation to replicate the Math library from Solana that can combine 2 Pyth Prices into 1 (SOL:USD/ETH:USD=SOL/ETH)
Functions replicated in Solidity for Ethereum's combine library
getPriceInQuote
div
normalize
MIN_PD_V_I64andMAX_PD_V_I64.scaleToExponent
toUnsigned
Added additional check to Return 0 values instead of throwing error so that it can be handled gracefully by the caller