Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resize mapping account #419

Merged
merged 5 commits into from
Jan 8, 2025
Merged

feat: resize mapping account #419

merged 5 commits into from
Jan 8, 2025

Conversation

Riateche
Copy link
Contributor

@Riateche Riateche commented Sep 9, 2024

After upgrading the program, other instructions using the mapping account will fail until the mapping account is resized.

Because of solana limitations, multiple transactions will be needed to resize the account.

product1.pubkey(),
product5.pubkey(),
product3.pubkey(),
product4.pubkey()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this file change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_account_data_as can no longer be used with MappingAccount because it's too large to fit on the stack, so I had to refactor this.

Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tejasbadadare
Copy link
Contributor

Removed the initPriceFeedIndex ix to reduce the binary size since it's no longer used. It's now deployable: Size of pyth_oracle.so is small enough to be deployed, since 87856 is less than 88429.

@ali-bahjati ali-bahjati merged commit 11bd882 into main Jan 8, 2025
3 checks passed
@ali-bahjati ali-bahjati deleted the resize-mapping branch January 8, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants