Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for maxLatency #76

Merged
merged 6 commits into from
Feb 28, 2024
Merged

feat: add support for maxLatency #76

merged 6 commits into from
Feb 28, 2024

Conversation

cctdaniel
Copy link
Contributor

No description provided.

@@ -285,10 +286,12 @@ export const parsePriceData = (data: Buffer, currentSlot?: number): PriceData =>
const timestamp = readBigInt64LE(data, 96)
// minimum number of publishers for status to be TRADING
const minPublishers = data.readUInt8(104)
// message sent flag
const messageSent = data.readUInt8(105)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by: previously added to the oracle program but js client wasn't updated

Comment on lines +401 to +402
export { pythIdl, pythOracleCoder, pythOracleProgram } from './anchor'
export { PythCluster, getPythClusterApiUrl, getPythProgramKeyForCluster } from './cluster'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by: format

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, you will also need to update the idl to support the new instruction SetMaxLatency, so maybe worth doing that before making a release

@cctdaniel cctdaniel changed the title add support for maxLatency feat: add support for maxLatency Feb 27, 2024
@@ -1,6 +1,6 @@
{
"name": "@pythnetwork/client",
"version": "2.19.0",
"version": "2.20.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the lockfile as well.

@cctdaniel cctdaniel merged commit 0ba9357 into main Feb 28, 2024
3 checks passed
@cctdaniel cctdaniel deleted the max-latency branch February 28, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants