feat: add initial cli #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Sep 4, 2024
staking/cli/Cargo.toml
Outdated
| bytemuck = {version = "1.4.0", features = ["derive", "min_const_generics"]} | ||
| byteorder = "1.4.3" | ||
| wormhole-vaas-serde = "0.1.0" | ||
| wormhole-solana-vaas = {version="0.3.0-alpha.1", features = ["anchor", "encoded-vaa", "mainnet"]} |
There was a problem hiding this comment.
I think this dep is unused
guibescos
reviewed
Sep 4, 2024
staking/cli/Cargo.toml
Outdated
| wormhole-vaas-serde = "0.1.0" | ||
| wormhole-solana-vaas = {version="0.3.0-alpha.1", features = ["anchor", "encoded-vaa", "mainnet"]} | ||
| serde_wormhole = "0.1.0" | ||
| serde_json = "1.0.125" |
guibescos
reviewed
Sep 4, 2024
staking/cli/Cargo.toml
Outdated
| wormhole-solana-vaas = {version="0.3.0-alpha.1", features = ["anchor", "encoded-vaa", "mainnet"]} | ||
| serde_wormhole = "0.1.0" | ||
| serde_json = "1.0.125" | ||
| solana-cli-output = "1.18.16" |
guibescos
reviewed
Sep 4, 2024
staking/cli/Cargo.toml
Outdated
| serde_wormhole = "0.1.0" | ||
| serde_json = "1.0.125" | ||
| solana-cli-output = "1.18.16" | ||
| spl-governance = { version = "4.0.0", features = ["no-entrypoint"] } |
guibescos
reviewed
Sep 4, 2024
staking/cli/Cargo.toml
Outdated
| solana-client = "1.18.0" | ||
| shellexpand = "3.1.0" | ||
| pythnet-sdk = {version = "2.3.0", features = ["test-utils"]} | ||
| bytemuck = {version = "1.4.0", features = ["derive", "min_const_generics"]} |
guibescos
reviewed
Sep 4, 2024
staking/cli/src/cli.rs
Outdated
| wormhole: Pubkey, | ||
| }, | ||
| InitializePoolRewardCustody {}, | ||
| UpdatePythTokenMint { |
There was a problem hiding this comment.
as said in the other pr I don't feel good keeping this instruction around
guibescos
reviewed
Sep 4, 2024
| data: wormhole_core_bridge_solana::instruction::VerifyEncodedVaaV1 {}.data(), | ||
| }; | ||
|
|
||
| process_transaction( |
There was a problem hiding this comment.
note: on mainnet, the vaa is bigger so we'll need to do this in multiple transactions like in write_publisher_caps, but we can fix that once we need it
guibescos
reviewed
Sep 4, 2024
staking/cli/src/instructions.rs
Outdated
| let encoded_vaa = process_write_encoded_vaa(rpc_client, vaa.as_slice(), wormhole, payer); | ||
|
|
||
|
|
||
| let publisher_caps = Keypair::new(); |
There was a problem hiding this comment.
init_publisher_caps could return the pubkey for publisher_caps
guibescos
reviewed
Sep 4, 2024
staking/cli/src/instructions.rs
Outdated
| let chunk = | ||
| &publisher_caps_message_bytes[i..min(i + 1000, publisher_caps_message_bytes.len())]; | ||
|
|
||
| write_publisher_caps(rpc_client, payer, publisher_caps.pubkey(), i, chunk); |
There was a problem hiding this comment.
feels like init_puiblisher_caps + write_publisher_caps and verify_publisher_caps should all be in 1 function
There was a problem hiding this comment.
they are all used in a function fetch_publisher_caps_and_advance
guibescos
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.