Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent Config.add_cleanup callbacks preventing other cleanups running #12982

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

prevent Config.add_cleanup callbacks preventing other cleanups running #12982

wants to merge 6 commits into from

Conversation

graingert
Copy link
Member

closes #12981

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 21, 2024
nicoddemus
nicoddemus reviewed Nov 21, 2024
View reviewed changes
src/_pytest/config/__init__.py Outdated Show resolved Hide resolved
changelog/12981.bugfix.rst Outdated Show resolved Hide resolved
src/_pytest/config/__init__.py Outdated Show resolved Hide resolved
@graingert graingert marked this pull request as ready for review November 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raising an exception in a callback to pytest.Config.add_cleanup doesn't allow subsequent cleanups to run.
2 participants
@graingert @nicoddemus