Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False)

[leonarduschen]

Closes #12849

---

Description:

• When ReprEntry.style == "value" (happens when calling pytest.fail(..., pytrace=False), the message should not be printed to terminal using TerminalWriter._write_source because then it'll try to highlight the message as source code
• The message should be printed to terminal directly using TerminalWriter.line or TerminalWriter.write, I went with the later for testing purposes Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False) #12959 (comment)

---

• Include documentation when adding new features.
• Include new tests or update existing tests when applicable.
• Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.
• Add text like closes #XYZW to the PR description and/or commits (where XYZW is the issue number). See the github docs for more information.
• Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
• Add yourself to AUTHORS in alphabetical order.

[leonarduschen]

Added this so that calling get_write_msg raises AssertionError instead of ValueError: Not enough values to unpack

I can revert it back if needed

[nicoddemus]

That's fine, thanks!

[leonarduschen]

Using TerminalWriter.write instead of TerminalWriter.line because when using TWMock . we can't distinguish lines written with TWMock._write_source and lines written with line directly, whereas with TWMock.write we can, with the flag.

We could add a flag for TWMock._write_source as well, like so:

class TWMock:
    WRITE = object()
    WRITE_SOURCE = object()

    def _write_source(self, lines, indents=()):
        if not indents:
            indents = [""] * len(lines)
        for indent, line in zip(indents, lines):
            newline = indent + line
            self.line((TWMock.WRITE_SOURCE, newline))

But then we'll have to change around half the test cases in test_excinfo.py

[nicoddemus]

Thanks for the explanation! I guess this rationale would be nice to have as a comment in the code itself, to help future readers.

[leonarduschen]

sure

[nicoddemus]

LGTM, thanks for the PR, appreciate it!

[nicoddemus]

Thanks for the explanation! I guess this rationale would be nice to have as a comment in the code itself, to help future readers.

[nicoddemus]

That's fine, thanks!

[nicoddemus]

Thanks @leonarduschen!

Will squash/merge in a few days to give others a chance to review it. 👍

[leonarduschen]

Sure thing @nicoddemus, thanks for the review! Excited for my first contribution :)