Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #12910
[pre-commit.ci] pre-commit autoupdate #12910
Changes from all commits
48bcb05
227b460
607b9f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 122 in src/_pytest/_io/pprint.py
Codecov / codecov/patch
src/_pytest/_io/pprint.py#L122
Check warning on line 182 in src/_pytest/capture.py
Codecov / codecov/patch
src/_pytest/capture.py#L181-L182
Check warning on line 555 in src/_pytest/capture.py
Codecov / codecov/patch
src/_pytest/capture.py#L555
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's a false positive, the return from read() is in fact
bytes
and not a buffer ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it can be a
ReadableBuffer
and notbytes
: https://github.com/python/typeshed/blob/ca65e08/stdlib/_io.pyi#L126C43-L126C57There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix something then (cast to str) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre-commit bot removed our changes, I force pushed them back :)