Fix pdb selftests on Python 3.13 #12885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
The-Compiler
added
the
backport 8.3.x
RonnyPfannschmidt
approved these changes
Oct 13, 2024
nicoddemus
approved these changes
Oct 13, 2024
changelog/12497.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fixed two failing pdb-related tests on Python 3.13. | |||
There was a problem hiding this comment.
Given this did not fix anything on pytest itself, only in the test suite, perhaps making this a misc changelog entry would be more appropriate?
There was a problem hiding this comment.
We have contrib too, which is described as:
stuff that affects the contributor experience. e.g.
Running tests, building the docs, setting up the development
environment.
That seems like a good fit given the "running tests" example.
Python 3.13 makes pdb break on the breakpoint() call, rather than on the next line: https://docs.python.org/3/whatsnew/3.13.html#pdb Also runs the pdb tests on Python 3.13 in CI. See pytest-dev#12884 for a more proper solution for that. Fixes pytest-dev#12497
The-Compiler
force-pushed
the
pdb-py311
branch
from
08fc277
to
f92597c
Compare
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #12887 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 13, 2024
Fix pdb selftests on Python 3.13 (cherry picked from commit a4e40bc)
nicoddemus
pushed a commit
that referenced
this pull request
Oct 13, 2024
Fix pdb selftests on Python 3.13 (cherry picked from commit a4e40bc) Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 makes pdb break on the breakpoint() call, rather than on the next line:
https://docs.python.org/3/whatsnew/3.13.html#pdb
Also runs the pdb tests on Python 3.13 in CI.
See #12884 for a more proper solution for that.
Fixes #12497