Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pytest_ignore_collect docs #12385

Merged
merged 2 commits into from
May 28, 2024
Merged

Clarify pytest_ignore_collect docs #12385

merged 2 commits into from
May 28, 2024

Conversation

nicoddemus
Copy link
Member

Fixes #12383

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you wrote it the way you did, but "consider this path to be considered for collection" sounded a bit clumsy to me... I put a suggestion to lean solely on the "ignore" terminology. But either way is OK by me.

src/_pytest/hookspec.py Outdated Show resolved Hide resolved
src/_pytest/hookspec.py Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member Author

I understand why you wrote it the way you did, but "consider this path to be considered for collection" sounded a bit clumsy to me... I put a suggestion to lean solely on the "ignore" terminology. But either way is OK by me.

Oh no I appreciate very much the suggestions -- I could not give this too much thought TBH, wanted to get the ball rolling and hoped a good review would improve my initial wording. So success! Hehehe.

@nicoddemus nicoddemus merged commit 9f121e8 into main May 28, 2024
26 checks passed
@nicoddemus nicoddemus deleted the ignore-collect-docs branch May 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest_ignore_collect documentation is misleading
2 participants