Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 compatibility to 4.6.x #11362

Closed
wants to merge 2 commits into from

Conversation

cielavenir
Copy link

This adds Python 3.11 compatibility to 2.7-compatible version.

hauntsaninja and others added 2 commits August 26, 2023 22:52
These are new additions in Python 3.8:
https://docs.python.org/3/whatsnew/3.8.html#ast
I'm not sure what's using them but we should set them anyway.
@nicoddemus
Copy link
Member

Thanks @cielavenir,

Unless I'm mistaken, we do not plan to have any more 4.6.x releases. Can somebody else from the core team confirm?

@The-Compiler
Copy link
Member

Agreed. The last 4.6.x release was over 3.5 years ago, and Python 2 has been EOL for just as long.

As per our contribution guide (emphasis mine):

Pytest makes a feature release every few weeks or months. In between, patch releases are made to the previous feature release, containing bug fixes only. The bug fixes usually fix regressions, but may be any change that should reach users before the next feature release.

@cielavenir
Copy link
Author

cielavenir commented Aug 28, 2023

our company just started Py3 migration and 4.6.x has to be used to maintain the transitional code base.

we can just build my branch internally, so this MR is like record, thanks

@The-Compiler
Copy link
Member

Sorry to be blunt here, but I feel like this needs to be said: You're at least 4 years late with that migration, and I'd expect many other projects to not be willing to spend any sort of resources on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants