Fix Issue #239 #240
Merged
Fix Issue #239 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metheuspsc Thank you for your contribution. Could you please undo the code formatting changes? This Project uses black to format the code which has its own strong opinion how to format the code, see https://github.com/pytest-dev/pytest-rerunfailures/actions/runs/6590126996/job/18552878766?pr=240 for details. |
metheuspsc
force-pushed
the
issue_239
branch
from
185eeb8
to
f412d3e
Compare
|
@icemac issues fixed! |
|
Currently flake8 crashes, let me update the pre-commit config in a separate PR. |
|
@metheuspsc Could you please rebase your branch onto the current master branch, so the flake8 crash hopefully gets fixed? |
metheuspsc
force-pushed
the
issue_239
branch
from
f412d3e
to
d896e71
Compare
|
Rebased! |
icemac
approved these changes
Nov 22, 2023
|
Thank you for this PR. 😃 |
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #239 and adds test coverage