Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qmlbot #476
base: master
Are you sure you want to change the base?
add qmlbot #476
Changes from 20 commits
0bc9a18
e3dcc0b
edd7257
24062d3
ccd6ce5
d55a3bb
dbc99ad
457f37f
ee69119
9383323
a8fa68c
59d5d7e
ac3a9bb
dd70ad8
716f4b8
02e9771
f2d0438
442e4b2
dca9399
bb9cb06
e472f83
ddd7cc9
355c377
e3dd1fc
4f783e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI decided to drop the
load(path: Path) -> Any
variant, because the user can easily just callloads(p.read_text(encoding=...))
instead ofload(p)
, with the advantage that we do not need to guess an encoding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, that is not the same. qml files can import other qml files based on relative path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow, what does the fact that "qml files can import other qml files" relates to being able to load a qml file passing a
Path
? Can you exemplify?Feel free to add it back, I removed because it seemed redundant and it the test was failing, but if it is not redundant we can revisit this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could though pass the pass in the url here
self._comp.setData(content.encode("utf-8"), qt_api.QtCore.QUrl())
I thinkthough I don't know if it is really the same under the hood. this way or another still worth to keep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In QML you can every file encapsulates a
Component
i.e ifMyApp.qml
lives nearmain.qml
You would do
and if i.e
MyApp.qml
resides in./impl/MyApp.qml
so you would need to importimpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh on CI it is showing the same error I got locally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. 👍