Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace asyncio.iscoroutinefunction with inspect.iscoroutinefunction #469

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Oct 24, 2024

DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead

Fixes #468

@hroncok
Copy link
Member Author

hroncok commented Oct 24, 2024

I still see the warning here when I run tox -e py314 because of pytest-asyncio. It is fixed there in pytest-dev/pytest-asyncio@d043698 but not yet released.


Also, about the CI failure... no idea what it means.

@nicoddemus
Copy link
Member

Hmm that's strange indeed, might be something temporary? Will try to restart CI a bit later to see if it goes away.

@webknjaz
Copy link
Member

@seifertm could you make a release if pytest-asyncio? Other plugins like pytest-mock start testing against Python 3.14 and hit that warning fixed in the main branch.

@nicoddemus
Copy link
Member

The failure is something related to hynek/build-and-inspect-python-package, because we are having the same error in #466, which ran fine two weeks ago.

DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead

Fixes pytest-dev#468
@nicoddemus
Copy link
Member

@hroncok rebased on main, which fixed the build-and-check-package problem.

@nicoddemus
Copy link
Member

Thanks @hroncok!

@nicoddemus nicoddemus merged commit 7724a9e into pytest-dev:main Oct 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated
3 participants