Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, add support for 3.12, 3.13 #842

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

Pierre-Sassoulas
Copy link
Member

No description provided.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@BeyondEvil
Copy link
Contributor

BeyondEvil commented Nov 19, 2024

Most errors are related to pkg_resources which I guess is entirely removed in 3.12.

However, the code:

    except AttributeError:
        # Needed for python < 3.9
        return pkg_resources.resource_string(
            "pytest_html", os.path.join("assets", "style.css")
        ).decode("utf-8")

We shouldn't hit.

So something is causing an attribute error here: https://github.com/pytest-dev/pytest-html/blob/master/testing/test_unit.py#L22

EDIT: Just realized we can just remove that code since we've dropped support for < 3.9. 🤷‍♂️

@BeyondEvil BeyondEvil force-pushed the back-to-green branch 2 times, most recently from b97fe87 to 87f105b Compare November 19, 2024 21:57
@Pierre-Sassoulas
Copy link
Member Author

Thanks for the review @BeyondEvil ! I did not manage to install locally yet (absolute path error I don't understand). Planning to work on this in the next few days and hopefully be able to reproduce the CI fail locally if adding setuptools doesn't work.

@BeyondEvil
Copy link
Contributor

Thanks for the review @BeyondEvil ! I did not manage to install locally yet (absolute path error I don't understand). Planning to work on this in the next few days and hopefully be able to reproduce the CI fail locally if adding setuptools doesn't work.

Ugh... windows builds are always sooo slow.

Anyway, I think it's fixed.

Re-add the devel stuff and I think we're good to merge. 👍

Thanks for the PR! ❤️ 🙏

@Pierre-Sassoulas
Copy link
Member Author

Nice ! Will do. I plan to merge all the dependabot one next, there's a bunch of pending cve warning that stressed me out :D

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for this PR! 🙏

@BeyondEvil BeyondEvil merged commit cc5e019 into master Nov 20, 2024
35 checks passed
@BeyondEvil BeyondEvil deleted the back-to-green branch November 20, 2024 12:30
@Pierre-Sassoulas
Copy link
Member Author

Thank you for fixing the pipeline, I had a hard time setting up the dev env locally to troubleshoot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants