-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .git-blame-ignore-revs #640
base: master
Are you sure you want to change the base?
Conversation
38adc16
to
50d5cee
Compare
@Pierre-Sassoulas Added the file to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
76fb2a6 could be removed from the git blame but not ff3fdd8 which introduce some non formatting changes (remove six, maybe others) and some unsafe fixes from ruff. I'm pretty sure the migration from os.path
to pathlib
is not automated either (I initially thought it was because of the MR ff3fdd8 was introduced in, until I actually tried and the deception was strong).
50d5cee
to
aff4437
Compare
I'd argue it's not just a formatting change but a functional one. F-strings are more performant so it's more of an enhancement rather than formatting. Usually only patches that are solely formatting are ignored. Bits that are useful for git paleontology aren't supposed to be hidden... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's the point of .git-blame-ignore-revs
in Manifest.in : after packaging git is not involved anymore, right ? So if f-strings removed from git blame are not consensual, there would be nothing left of this MR if we also remove that 😅
Without it there, |
What is check-manifest and why does it fail ? manifest.in is linked to python packaging and does not involve git, right ? |
@ionelmc this file is picked up by GitHub automatically, and it hides the listed commits from blame, unlike local Git invocations where that needs to be configured. |
Have you considered using |
This makes GitHub (and other tools that support this file, or any Git client with
git config blame.ignoreRevsFile .git-blame-ignore-revs
set) ignore the large reformatting/automatic commits, to make blame inspection easier.