Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scenario descriptions #600

Merged
merged 9 commits into from
Feb 27, 2023

Conversation

pbarnajc
Copy link
Contributor

@pbarnajc pbarnajc commented Feb 9, 2023

Fixes #311

Adds descriptions to Scenarios and Scenario Outlines to better fit the Gherkin syntax specifications.

@pbarnajc pbarnajc marked this pull request as draft February 9, 2023 21:10
@pbarnajc pbarnajc marked this pull request as ready for review February 16, 2023 19:17
@pbarnajc pbarnajc changed the title Scenario descriptions Add support for Scenario descriptions Feb 16, 2023
youtux
youtux previously approved these changes Feb 26, 2023
Copy link
Contributor

@youtux youtux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took so long to review it. Would you add this to the CHANGELOG.rst? I'll try to merge it and make a release next weekend.

src/pytest_bdd/parser.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 95.43% // Head: 95.40% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (ad6df6e) compared to base (d71bb90).
Patch coverage: 94.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   95.43%   95.40%   -0.03%     
==========================================
  Files          49       49              
  Lines        1751     1764      +13     
  Branches      189      193       +4     
==========================================
+ Hits         1671     1683      +12     
  Misses         53       53              
- Partials       27       28       +1     
Impacted Files Coverage Δ
src/pytest_bdd/parser.py 98.63% <93.75%> (-0.40%) ⬇️
tests/feature/test_description.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@youtux youtux disabled auto-merge February 27, 2023 20:00
@youtux youtux merged commit b5f90f6 into pytest-dev:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenario descriptions cause odd results
2 participants