Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra create_file from troubleshooting snippet #875

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Removed extra create_file from troubleshooting snippet #875

merged 3 commits into from
Aug 26, 2023

Conversation

jamesbraza
Copy link
Contributor

@jamesbraza jamesbraza commented Aug 26, 2023

  • Noticed syntax highlighting needed an update
    • Single backtick means italics, double backtick means code syntax
  • Fixed wording from "type" to "attributes"
  • Realized to make the point in the code snippet about Path, don't need create_file at all

For #872

@mrbean-bremen
Copy link
Member

Thanks - I will leave this open for a while, in case you find more stuff...

@jamesbraza
Copy link
Contributor Author

I already merged changes in my employer's codebase that implements all of these learnings, so the case is closed on my end. Apologies for 2nd PR, always hunting for the true minimal repro 🔍 😄

@mrbean-bremen
Copy link
Member

No apologies needed 😀

@mrbean-bremen mrbean-bremen merged commit 48608b4 into pytest-dev:main Aug 26, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants