Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement legacy hookwrappers in terms of a modern hook" #546

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: implement legacy hookwrappers in terms of a modern hook" #546

wants to merge 3 commits into from

Commits on Nov 3, 2024

  1. fix pytest-dev#544: Correctly pass StopIteration trough wrappers 

    Raising a StopIteration in a generator triggers a RuntimeError.
If the RuntimeError of a generator has the passed in StopIteration as cause
resume with that StopIteration as normal exception instead of failing with the RuntimeError.
    @RonnyPfannschmidt
    RonnyPfannschmidt committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    9cf2eaa View commit details
    Browse the repository at this point in the history

  2. move legacy hookwrapper implementation into a own new style generator 

    this trades speed of the legacy hooks for a much simpler and safe implementation of the hook call loop
    @RonnyPfannschmidt
    RonnyPfannschmidt committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    d249bd5 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. WIP: move legacy hook result trigger outside of the except block

    @RonnyPfannschmidt
    RonnyPfannschmidt committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ea049ed View commit details
    Browse the repository at this point in the history