-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some steps towards exporting our typings #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default <2 is used, but we want to use new features. Refs pytest-dev#428
So it doesn't overflow to the content. Probably there's a better fix for this.
For typing purposes, refs pytest-dev#428. The old name `pluggy._result._Result` is kept for backward compatibility, no reason to break the "offenders" who have imported it before.
For typing purposes, refs pytest-dev#428. The old name `pluggy._hooks._HookCaller` is kept for backward compatibility, no reason to break the "offenders" who have imported it before.
For typing purposes, refs pytest-dev#428. The old name `pluggy._hooks._HookRelay` is kept for backward compatibility, no reason to break the "offenders" who have imported it before.
For typing purposes, refs pytest-dev#428.
Note: I will add a changelog entry detailing all of the changes once I'm finished with the issue. |
nicoddemus
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
"""Hook holder object for performing 1:N hook calls where N is the number | ||
of registered plugins.""" | ||
|
||
__slots__ = ("__dict__",) | ||
|
||
def __init__(self) -> None: | ||
""":meta private:""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles some items from #428, but not finished yet.