Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to hatch + move importlib hacks to own module for typing #362

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RonnyPfannschmidt
Copy link
Member

No description provided.

@RonnyPfannschmidt
Copy link
Member Author

readthedocs seems to lack support for modern builds

@RonnyPfannschmidt
Copy link
Member Author

fixed the issues, will need to add some docs later today

@RonnyPfannschmidt
Copy link
Member Author

@pytest-dev/core this also serves as first example for going away from setuptools, please have a look

@RonnyPfannschmidt
Copy link
Member Author

will squash locally after approval

@RonnyPfannschmidt
Copy link
Member Author

Will reorder the commit content today to split the meaning

@RonnyPfannschmidt
Copy link
Member Author

@nicoddemus i'd appreciat another look over before merging the split commits

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Comment on lines +28 to +31
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Programming Language :: Python :: 3.10",
Copy link
Member

@nicoddemus nicoddemus Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it now, the tool seems to work as expected.

I think we should also update the deploy workflow to use hatch, after all its main purpose is to do the build (and maybe publish) no?

"Topic :: Utilities",
]
dependencies = [
"importlib-metadata>=0.12;python_version<\"3.8\"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think can use ' here to avoid the escaping

Suggested change
"importlib-metadata>=0.12;python_version<\"3.8\"",
'importlib-metadata>=0.12;python_version<"3.8"',

@nicoddemus
Copy link
Member

@bluetech good catch, I think you mean these places?

pip install --upgrade wheel setuptools setuptools_scm

python -m pip install --upgrade pip setuptools

run: python setup.py sdist bdist_wheel

@bluetech
Copy link
Member

bluetech commented Oct 6, 2022

Yes exactly. I'm not sure if we want to keep using the pypa/gh-action-pypi-publish action or switch to using hatch publish, I'll leave it to @RonnyPfannschmidt to decide.

hooks:
- id: blacken-docs
additional_dependencies: [black==21.7b0]
additional_dependencies: [black==22.6.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the one above:

Suggested change
additional_dependencies: [black==22.6.0]
additional_dependencies: [black==22.8.0]

@@ -1,4 +1,5 @@
[tox]
isolated_build = True
envlist=linting,docs,py{36,37,38,39,310,py3},py{36,37}-pytest{main}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
envlist=linting,docs,py{36,37,38,39,310,py3},py{36,37}-pytest{main}
envlist=linting,docs,py{37,38,39,310,py3},py{37}-pytest{main}

@KOLANICH
Copy link

There is an issue: hatchling itself depends on pluggy.

@ssbarnea
Copy link
Member

ssbarnea commented Jul 1, 2023

I am against this as I prefer setuptools-scm, but I will not block the change.

@RonnyPfannschmidt
Copy link
Member Author

Hatch VCS uses Setuptools-scm

@RonnyPfannschmidt
Copy link
Member Author

This is currently indefinitely blocked as the dependency loop with hatchling needs a resolution

@KOLANICH
Copy link

KOLANICH commented Jul 1, 2023

Do I understand right that only migration to hatchling is blocked, but the rest of changes ("move importlib hacks to own module for typing") are not blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants