Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for getting/setting RDII parameters #266

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

sm-rana
Copy link

@sm-rana sm-rana commented Jan 15, 2020

The API for getting/setting RDII parameters can be useful during the calibration or RTK values using measured flow/depth data.

@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

Merging #266 into develop will increase coverage by 2.52%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
+ Coverage    62.66%   65.19%   +2.52%     
===========================================
  Files           53       53              
  Lines        16718    16786      +68     
===========================================
+ Hits         10477    10944     +467     
+ Misses        6241     5842     -399
Impacted Files Coverage Δ
src/toolkitAPI.c 67.75% <88.23%> (+1.3%) ⬆️
src/massbal.c 79.02% <0%> (+0.21%) ⬆️
src/input.c 74.14% <0%> (+1.7%) ⬆️
src/swmm5.c 86.97% <0%> (+1.86%) ⬆️
src/node.c 59.27% <0%> (+1.91%) ⬆️
src/gage.c 64.91% <0%> (+2.19%) ⬆️
src/report.c 84.09% <0%> (+2.2%) ⬆️
src/routing.c 68.21% <0%> (+2.31%) ⬆️
src/datetime.c 75.56% <0%> (+2.84%) ⬆️
src/inflow.c 80.2% <0%> (+4.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c43f0...33ad81b. Read the comment docs.

@bemcdonnell
Copy link
Member

@sm-rana, can you fill out the Contributors License Agreement? CLAHUB

@bemcdonnell
Copy link
Member

@sm-rana I'm going to start working on this PR again :)

@bemcdonnell
Copy link
Member

@sm-rana it is also apparent to me that you were PR +900,000 lines of changes!!!! You're trying to break a world record!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants