Get/Set Storage Nodes Parameters

[joaolponciano]

Closes #189

Hello Bryant,

Here are the modifications we was talking about. I'm not so sure about the units.
As I told you before this is the first time I am working in GitHub, so I might have made some mistakes, I'm sorry about them. Thanks for your help and attention.

Thanks,
João.

[bemcdonnell]

@joaolponciano, please migrate all this code to the toolkitAPI.c module. It appears that you have a syntax error somewhere as well. In response to your comment on Units, look at how other getter/setters work. When you set a value, the units are converted on the way in. when you get a value, the units are converted on the way out. Make sure you multiple.divide correctly. I also believe that there are three parameters that make up a functional storage curve (you seem to only have aCoeff). Can you check that?

[bemcdonnell]

@joaolponciano, also please sign the contributors license agreement HERE

[dickinsonre]

There are three parameters in a storage function

Area = A + B^C though you can get by just using A.

[joaolponciano]

@bemcdonnell, thanks again for the help. I checked the points you told me to, and corrected them, thanks. I'm just checking the syntax yet. To migrate the code for toolkitAPI.c should I close this pull request and create another one or it's possible to put the code here?

[bemcdonnell]

@joaolponciano, just move the code (please put your functions around similar functions for nodes), delete the toolkitAPImodified.c file, and make another commit with these changes. There are going to be lots of additional commits that will ride inside your PR.

Once we agree on the function "themes", you'll need to add unit tests as well so we can always be sure this code is working. You'll also need to add your function declarations to /include/toolkitapi.h

Once we are all satisfied with the implementation and tests, we will approve the PR and your code will come into SWMM. Also, at this point, go ahead and append your name to the AUTHORS file so we can more easily associate your changes with you.

[joaolponciano]

@bemcdonnell, I think the last commit I uploaded meets the first requests you did. Should I add the function declarations to /include/toolkitapi.h already?

Thanks for all your help.
João

[bemcdonnell]

@joaolponciano You code is very far out of date based on where the OWA develop branch is. Could you rebase your work please? Also it appears to be failing to build on Appveyor.

[joaolponciano]

@bemcdonnell, Should I rebase them to develop? And I will check what is failing in Appveyor.

Thanks.

[bemcdonnell]

@joaolponciano, Sorry that things got really busy 5 years ago! @karosc, I am going to bring this PR back to life. It is a really great contribution!