Maven mgs

[t-esman]

Description

Addresses #(issue)

Adds MAVEN pysat compatibility (No specific issue number).

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

    import pysat
    from pysat.utils import registry
    registry.register_by_module(pysatNASA.instruments)

    mag = pysat.Instrument(platform='maven', name='mag')
    mag.download(dt.datetime(2020, 1, 1), dt.datetime(2020, 1, 31))
    mag.load(2020, 1, use_header = True)

Test Configuration:

• Operating system: Ventura
• Version number: Python 3.9.13
• Any details about your local setup that are relevant

Checklist:

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• Add a note to CHANGELOG.md, summarizing the changes
• Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

[jklenzing]

It looks like a new dataset for ISS FPMU was uploaded, which is breaking the tests here. Out of scope for this PR.

[jklenzing]

It looks like a new dataset for ISS FPMU was uploaded, which is breaking the tests here. Out of scope for this PR.

Added Issue #201 to cover the ISS FPMU bug. This is an upstream issue, so ignore it for the time being in the tests.

[jklenzing]

This is looking good. Instruments load data and metadata as expected.

Some style suggestions and updates based on the latest version. Examples applied to the insitu instrument, but changes should be similar for the others as well.

Also, please update the documentation for supported instruments: https://github.com/pysat/pysatNASA/blob/maven_mgs/docs/supported_instruments.rst

Thanks for putting this together!

[jklenzing]

Pinging @JonathonMSmith to see if the new cdasws routines could help streamline the new instruments as well.

[jklenzing]

Hmm. The insitu data is now having issues with loading. Verified this via loading locally. Getting an error via xarray:

ValueError: broadcasting cannot handle duplicate dimensions on a variable: ['time', 'compno_3', 'compno_3']

The issue is with the general cleaning routine. fix incoming...

[JonathonMSmith]

Since none of these datasets have monthly files this is good, but should we use the cdasws interface for MAVEN.
I'm still not sure that the cdasws interface is ideal for all of our NASA instruments but I can put together some suggestions if we want to use it here.

[jklenzing]

I'll put together a pull to fix the clean routines

[jklenzing]

Change to allow a list of variables to skip as an optional kwarg.

[jklenzing]

Clean routine incoming via pull request. A few suggestions here, otherwise looking good and working as expected.

Noting that there are a few instances where the time index is NaN in the sep file.

[jklenzing]

One more change: The standard elsewhere has been to have a mission-level reference that gets added to each instrument (this happens in the standard init routine). Since insitu_kp is copying multiple instruments, leaving this blank and just using the mission level is probably fine here.

[jklenzing]

Minor updates, looking good.

[jklenzing]

Looks good!