Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Candidate 0.0.5 #61

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

Release Candidate 0.0.5 #61

wants to merge 66 commits into from

Conversation

jklenzing
Copy link
Member

Description

Maintenance update to keep code / docs up to standard.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested in CI env.

Test Configuration:

  • Operating system: mac, ubuntu, windows
  • Version number: Python 3.9-12

Checklist:

  • Update the version number
  • Verify and update Zenodo information in .zenodo.json
  • doc tests pass locally
  • activate this branch on readthedocs (include link here)
  • Upload the test distribution to the testPyPi server
  • Contacted developers and users about the future release
  • Performed integration tests with downstream packages (include list of these packages)
  • Create a wiki page with the release text (put link here)
  • After approval, confirm all changes from the RC pull are listed in the wiki release text.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

jklenzing and others added 30 commits August 15, 2023 10:29
@jklenzing
Merge pull request #50 from pysat/main
b753d06 
Pull 0.0.4 changes into develop
@jklenzing
MAINT: update workflows
9d3413c
@jklenzing
DOC: update changelog
2e3965d
@jklenzing
MAINT: version cap for sphinx rtd theme
62087c8
@jklenzing
MAINT: pysat 3.2.0 compat
af8d257
@jklenzing
MAINT: turn off new tests for gps
1c682e7
@jklenzing
MAINT: set version limit for pysat
7ffde7c
@jklenzing
DOC: add issue to TBD
d1bafd1
@jklenzing
TST: verbose tests
37a3b89
@jklenzing
MAINT: update GA versions
11e3bf6
@jklenzing @aburrell
Apply suggestions from code review
7aaf5eb 
Co-authored-by: Angeline Burrell <[email protected]>
@jklenzing
Update NEP29 tests
b3c12e3
@jklenzing
Merge pull request #52 from pysat/maint/rc
bdd2ee6 
MAINT: pysat 3.2.0 RC compliance
@jklenzing
Update requirements.txt
706849e
@jklenzing
Merge pull request #55 from pysat/jklenzing-patch-1
d6442eb 
Update requirements.txt
@Aadarsh-Govada
Create patch.yml
fe30451
@Aadarsh-Govada
Add source installation of pysat patch-develop branch
68e0e9a
@Aadarsh-Govada
Add -y to pip uninstall
7a7b7fc
@Aadarsh-Govada
STY: Update python versions in main workflow
7ff9aaf
@Aadarsh-Govada
TST: Use patched pysat rc for patch workflow
886bafe
@Aadarsh-Govada
Update patch.yml
8721178
@Aadarsh-Govada
Cap numpy at 3.2.0
c102a8a
@Aadarsh-Govada
BUG: Remove numpy 3.2.0 cap and update to 'np.prod()'
282de5d
@Aadarsh-Govada
Delete .github/workflows/patch.yml
f26c5ce
@Aadarsh-Govada
DOC: Update .zenodo.json
a971074
@jklenzing
Update CHANGELOG.md
9fd6dd3
@jklenzing
Merge pull request #56 from pysat/patch-develop
3fe6c3a 
BUG: Update deprecated numpy product usage
@Aadarsh-Govada
MAINT: Update deprecated 'Dataset.dims' usage to 'Dataset.sizes'
567ad37
@Aadarsh-Govada
Undo previous commit
254f00f
@Aadarsh-Govada
Update deprecated 'Dataset.dims' usage to 'Dataset.sizes'
4ef4a4b
jklenzing
jklenzing commented Nov 13, 2024
View reviewed changes
CHANGELOG.md Outdated
* Update GitHub Actions standards, including SPEC-0 tests
* Add compatibility for numpy version>=3.2.0
* Update usage of 'Dataset.dims' to 'Dataset.sizes'
* Update compatibility with pysat 3.2.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Update compatibility with pysat 3.2.0
* Update compatibility with pysat 3.2.1

aburrell
aburrell approved these changes Nov 18, 2024
View reviewed changes
.github/workflows/pysat_rc.yml Show resolved Hide resolved
@rstoneback
Copy link
Collaborator

I can move forward on this once #63 is sorted.

@rstoneback
Merge pull request #63 from pysat/controlled_information
31285b5 
LGL: Update controlled information statement for clarity and accuracy
rstoneback
rstoneback reviewed Jan 13, 2025
View reviewed changes
pysatCDAAC/tests/test_instruments.py

# Confirm length of each profile corresponds to bin_num
assert self.test_inst.data.dims['RO'] == bin_num
assert self.test_inst.data.sizes['RO'] == bin_num
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change very sensitive to xarray versions?

Copy link
Member Author

@jklenzing jklenzing Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First added in v0.9.0 (2017). The deprecation of dims went in place in 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell approved these changes

@rstoneback rstoneback rstoneback approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jklenzing @rstoneback @aburrell @Aadarsh-Govada