Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysam
does not currently export the various wrapper functions in thesamtools
module, resulting in type-checking errors.e.g.
I've followed the pattern implemented in the other modules, exporting attributes in a module-specific
__all__
declaration and then adding this list to the package's__all__
.I believe this PR addresses the problem, but I'm unable to verify - when I install the updated package locally with
pip install -e
,mypy
cannot find the type stubs forpysam
. (As an aside - is there aCONTRIBUTING
or other documentation for local install/testing?)Thanks!