integrate smaup into tobler #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wrapper function over esda smaup - just tell user whether or not variable is affected by MAUP, if they want more info they should run it themselves for now - allow user to pass own regions and weights object in smaup_kwds - begin diagnostics module - only import warn from warnings
sjsrey
reviewed
Apr 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 81.25% 80.52% -0.73%
==========================================
Files 17 20 +3
Lines 832 873 +41
==========================================
+ Hits 676 703 +27
- Misses 156 170 +14
Continue to review full report at Codecov.
|
- the paper recommends using Rook, so use that as default. - we can get the number of regions to be agreggated to from the target_df's length, so use that for `k`. - move to smaup_weight
- now tests a real interpolation situation pulled straight from the notebooks
copy paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esdasmaupsmaup_kwdsdiagnosticsmoduleAddresses #51 and partially #84
This implementation does not automatically run
smaup. It requires that the user pass their own weights object to calculate Moran's I, and choose the number of regions that they will be runningsmaupagainst. It also does not prioritize user interaction with the statistic (I suppose you could import the wrapper function itself and run it), it only tells the user whether the variable being used is affected by the MAUP.Let me know what you think