modernize infrastructure #121
Conversation
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
=====================================
Coverage 69.1% 69.1%
=====================================
Files 40 40
Lines 8723 8723
Branches 1195 1253 +58
=====================================
Hits 6027 6027
Misses 2316 2316
Partials 380 380
|
|
@pedrovma this should be ready. Doesnt touch any substantive code, but brings infrastructure in line with the rest of the ecosystem |
|
This is great! Thank you so much. |
| default: test | ||
| required: false | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Do we still have a master here?
| strategy: | ||
| matrix: | ||
| os: ['ubuntu-latest'] | ||
| environment-file: [ci/310.yaml] | ||
| environment-file: [.ci/39.yml] |
There was a problem hiding this comment.
Why downgrade to 39 from 310 here? Probably should actually be 311.
| "pytest-mpl", | ||
| "pytest-cov", | ||
| "watermark", | ||
|
|
| ] | ||
| requires-python = ">=3.8" | ||
| dependencies = [ | ||
| "scipy>=0.11", |
| "Intended Audience :: Science/Research", | ||
| "Topic :: Scientific/Engineering :: GIS", | ||
| ] | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
| requires-python = ">=3.8" | |
| requires-python = ">=3.9" |
| - name: setup micromamba | ||
| uses: mamba-org/provision-with-micromamba@main | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
What's the need for this cache action?
| import sphinx_bootstrap_theme | ||
|
|
||
|
|
||
| sys.path.insert(0, os.path.abspath("../")) |
There was a problem hiding this comment.
This is not needed? It seems to still be needed in spaghetti.
There was a problem hiding this comment.
im not sure about this. I've had to remove it from tobler and segregation otherwise the docs build will fail
| - name: commit docs | ||
| path: ~/conda_pkgs_dir | ||
| key: ${{ matrix.os }}-conda-${{ env.CACHE_NUMBER }}-${{ hashFiles(matrix.environment-file) }} | ||
| - uses: conda-incubator/setup-miniconda@v2 |
There was a problem hiding this comment.
Is there a reason for not using the mamba-org/setup-micromamba@v1 action here?
There was a problem hiding this comment.
no... which package has the most current recipes?
There was a problem hiding this comment.
That's a good question... seems to be a hodgepodge
|
thanks for the close review james! All of the recipes are basically just copied over from tobler, so there may be cases like v3 vs v4 that can be directly updated. |
LOL I can read this as "dang it, James". Those versions are probably not going to cause much problem for now. At some point in the future *waves hands ambiguously*, we should actually hammer out all the inconsistencies across the ecosystem. Alas, there are only so many hours in the day. |
| - ci/39.yaml | ||
| - ci/310.yaml | ||
| - ci/310-BASE.yaml | ||
| - ci/310-DEV.yaml | ||
| - ci/311.yaml | ||
| include: | ||
| - environment-file: ci/310.yaml |
There was a problem hiding this comment.
Should be testing against 311 for the macOS and Windows environments.
not even close. this is exactly why i tag you for review! :) |
No description provided.