Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make CI run #128

Merged
merged 8 commits into from
Oct 12, 2023
Merged

CI: make CI run #128

merged 8 commits into from
Oct 12, 2023

Conversation

martinfleis
Copy link
Member

Minor update trying to make CI run again. Now it fails on install.

@jGaboardi jGaboardi merged commit d9c8aaf into pysal:master Oct 12, 2023
6 checks passed
@martinfleis martinfleis deleted the ci_run branch October 12, 2023 13:23
@knaaptime
Copy link
Member

ive done that copy/paste a million times. Do we want to standardize this convention? Personally i prefer the hidden dir with the . prefix

@martinfleis
Copy link
Member Author

For the location of CI envs?

@jGaboardi
Copy link
Member

jGaboardi commented Oct 12, 2023

Do we want to standardize this convention?

Very much yes! I prefer non-hidden, but don't have a strong opinion on it (for once :P).

@martinfleis
Copy link
Member Author

I'd also prefer non-hidden but equally don't care.

@knaaptime
Copy link
Member

it's always felt more like an auxiliary directory to me, only useful for the cloud-based workflows, not the 'user', so it feels natural to hide it just like the .github dir to clean up the structure a bit

But i also dont feel very strongly about it--and im already outvoted, so just fine to change

@jGaboardi
Copy link
Member

Let's one of use make an issue for this in the submodule template to not forget. Then we can get started standardizing the repos.

@martinfleis
Copy link
Member Author

only useful for the cloud-based workflows

I'm using those to setup my dev envs because these are more likely up to date than some dev env file created 4 years ago :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants