Snuffling Quick Save #25
Conversation
There was a problem hiding this comment.
Thank for this feature! :)
I made some minor suggestions to the code, also @HerrMuellerluedenscheid should have a look.
quick_save.py
Outdated
|
|
||
| # TO-DO - save to VELEST format. | ||
|
|
||
| user_def_root_folder = \ |
There was a problem hiding this comment.
Capitalize this constant and default to the user's home folder: os.path.expanduser('~')
quick_save.py
Outdated
| def __snufflings__(): | ||
| """Returns a list of snufflings to be exported by this module.""" | ||
|
|
||
| return[QuickSave()] |
There was a problem hiding this comment.
I noticed that empty lines at EOF are automatically truncated.
There was a problem hiding this comment.
Now it worked. It was editor's fault.
|
Good. I will wait for additional comments and then apply the proposed changes. Gregor |
quick_save.py
Outdated
| @@ -225,5 +222,5 @@ def call(self): | |||
| def __snufflings__(): | |||
| """Returns a list of snufflings to be exported by this module.""" | |||
|
|
|||
| return[QuickSave()] | |||
| return[ QuickSave() ] | |||
There was a problem hiding this comment.
missing whitespace, please remove the added white spaces again. this does not follow pep8 ...
|
Hey @grajh After quite some time I had a quick look again into your source code. Do I get it right that this snuffling is saving markers in a format that is suitable for the inversion tool Velest? |
|
Hi! Yes, this is basically it. Till now i just oppened terminal and run it separately. One more thing comes to my mind for the future. I could also implement a procedure which would allow to read already existing VELEST file and merge it with current picks by overwriting or adding picks to existing file. This functionality could be merged with default marker opening procedure in Snuffler. |
Hi!
For my needs I wrote a snuffling, which allows me to save markers more efficiently (predefined folder) and based on the name of an active event.
I guess some else could also benefit from it.
Gregor