Fixing SAML redirect handling

pyro2927 · Sep 21, 2024 · 2cb47cc · 2cb47cc
1 parent 908b7e7
commit 2cb47cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/containerize.js b/containerize.js
@@ -175,6 +175,7 @@ function listener(details) {
 
   return {};
 }
+
 function accountNameListener(details) {
   // Intercept our response
   let filter = browser.webRequest.filterResponseData(details.requestId);
@@ -208,17 +209,17 @@ function accountNameListener(details) {
   }
 
   return {};
-
 }
 
 async function samlListener(details) {
+  // check to make sure we only handle this on redirects
+  if (details.statusCode != 302) {
+    return {};
+  }
+
   async function process(result) {
     onGot(result);
 
-    if (details.statusCode != 302) {
-      return {};
-    }
-
     const setCookie = details.responseHeaders.find(header => header.name == "set-cookie");
     const redirectUrl = details.responseHeaders.find(header => header.name == "location").value;
 

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 2,
   "name": "AWS SSO Containers",
-  "version": "1.10",
+  "version": "1.11",
   "description": "Automatically places AWS SSO calls into containers.",
   "browser_specific_settings": {
     "gecko": {