Draft of switch StudentT
cdf
to use tfp's betainc
#1475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax's
betainc
doesn't have gradients defined for all parameters while tfp's does.See the related PR here: #1471 and the initial discussion here: #1452.
I'm not sure exactly how you want to handle the dependency declarations since
tensorflow
andtensorflow-probability
are sort of heavy dependencies to bring in (i.e. should they be promoted toinstall_requires
?).Also, the type casting stuff is a bit ugly but tfp checks that array types match and
self.df
sometimes had afloat64
dtype in tests whilebeta_value
has afloat32
dtype in each test.