Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preflight checks hackathon 2024 #2454

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    094b9cc View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Fix Model Checker Attribute Error

    This Error has been lingering for a while, I decided to give it a shot.
    Causes:
    1- Document is not workshared, OR
    2- The script is trying to get the .Name and .Category of document objects that doesn't own these attribute objects, this is typical for dependent elements such as sketchplanes, graphicOverrides, roomboundaries.
    
    Solution:
    Filter out element that doesn't have a name or a category and sort them under a seperate list called "Unassigned"
    
    Give it a try.
    tay0thman committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d364f37 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Create radar_check.py

    This Model Checker swiftly verifies the extents of the Revit model. 
    Placing model extents more than 10 miles from the project's 
    internal origin can lead to issues with accuracy, tolerance, 
    performance, and viewport display. This check ensures that the 
    model remains within a 10-mile radius of the internal origin.
    tay0thman authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6d3b4f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    67480d3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2413 from tay0thman/develop

    Fix Model Checker Attribute Error
    jmcouffin authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c58a784 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge pull request #2414 from tay0thman/patch-4

    Create radar_check.py
    jmcouffin authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    466aae9 View commit details
    Browse the repository at this point in the history
  2. Update radar_check.py - Rev1

    Made the changes below per Jean-Marc's feedback.
    
    1- you may want to present digits results in a tabular form for readability and ease in comparison.
    
    Response: Added output.print_table
    
    2- the project base point cannot be placed at more than 10 miles in more recent version of Revit
    
    Response: Good to know! I removed the report for the location of the project basept.
    
    3- you may want to use the convert unit util to display the distances in the same units as in the UI
    
    Response: I used the unitutils to convert the internal distances to the model distances, however in metric I am having hard time to show the suffix (mm, M, km)....etc
    
    4- you may want to limit the amount of objects output in the output windows using linkify as it may greatly slow the tool
    
    Response: Set the limit of linkify to 10 prints per category, if there are more violating objects, then it will show a message "Manual investigation is required"
    
    5- I tend to prefer print_md over print_html as it is more efficient and improves readability
    
    Response: I switched most of them to use print_md. also I used pyrevit emojis instead of html colors.
    
    
    
    please take a look and let me know if this makes sense.
    tay0thman authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    de6ab85 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge pull request #2418 from tay0thman/patch-5

    Update radar_check.py - Rev1
    jmcouffin authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c0c2fcf View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Create CADAUDIT_check.py

    My proposal for a comprehensive audit of cad instances. See details described in the ModelChecker class comments.
    It would replace the old LISTDWGs by F. Beaupere, from the Project panel, link tools.
    Bonus: It also extends the basic functionality of RPW by adding radio buttons and a cancel button.
    nasmovk authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ac74b95 View commit details
    Browse the repository at this point in the history
  2. Update radar_check.py

    Updated the script for better compliance and fixed issues reported by @jmcouffin and @dosymep
    tay0thman authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    13c98b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge pull request #2425 from tay0thman/patch-6

    Update radar_check.py - Code Cleanup, expanding tabulated info
    jmcouffin authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f8a7011 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Create Naming_Convention_Check

    This code is based on a true story.
    
    Naming conventions are the foundation of a project. Naming is essential for model checks, filters, and view settings. Until now, I created my checks using Revit export text files with Power-BI. PyRevit enables continuous checking of all categories against their predefined names with just a click.
    andreasdraxl authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d351df6 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Update radar_check.py - Rounding Coordinates

    Added basic rounding for coordinates for better readability,
    tay0thman authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    700534c View commit details
    Browse the repository at this point in the history
  2. Create wall_list.json

    A template for a loadable .json file.   Just a list of strings.
    andreasdraxl authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2f6f786 View commit details
    Browse the repository at this point in the history
  3. Update and rename Naming_Convention to Naming_Convention_Check.py

    update extionsion.py added.   file.json template list-template added.
    andreasdraxl authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    05b7052 View commit details
    Browse the repository at this point in the history
  4. Update Naming_Convention_Check.py

    replace static path by select_file(*.json)
    andreasdraxl authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    91ea604 View commit details
    Browse the repository at this point in the history
  5. Update Naming_Convention_Check.py

    add rpw module
    andreasdraxl authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3626f35 View commit details
    Browse the repository at this point in the history
  6. Update Naming_Convention_Check.py

    add a default path, just for having more confort
    andreasdraxl authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a24cb36 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge pull request #2442 from tay0thman/patch-8

    Update radar_check.py - Rounding Coordinates
    jmcouffin authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7661032 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b70dccf View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    d6beb74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ef1bea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da42ec6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    298c1d0 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #2453 from jmcouffin/patch-2

    walltypes_naming_convention_check
    jmcouffin authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a18c4bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f9d66d8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    06b79cd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9fd9c57 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    44c4ce4 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #2423 from nasmovk/patch-1

    Create CADAUDIT_check.py
    jmcouffin authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c771c27 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. small fixes to checks

    jmcouffin authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b5003bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74d902f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e9ec311 View commit details
    Browse the repository at this point in the history
  4. Update walltypes_naming_convention_check.py

    - set default path properly
    - using pick_file instead or select_file from rpw
    jmcouffin authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    99587e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    59bc9bf View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    e907472 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fabdad2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b9ae71 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    192ff7e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c960997 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    32d60a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    02af5b5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0bfbfff View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    73c0c9e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b735d2d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4435761 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9818045 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9300840 View commit details
    Browse the repository at this point in the history
  14. Apply suggestions from code review

    Co-authored-by: Andrea Ghensi <[email protected]>
    jmcouffin and sanzoghenzo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    91c8475 View commit details
    Browse the repository at this point in the history
  15. Apply suggestions from code review

    Co-authored-by: Andrea Ghensi <[email protected]>
    jmcouffin and sanzoghenzo authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    26a2707 View commit details
    Browse the repository at this point in the history
  16. Update walltypes_naming_convention_check.py

    renamed wall list loader to pick json
    jmcouffin authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    2718ef9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Update radar_check.py

    updates per the recent feedback by @sanzoghenzo  and @dosymep 
    1- I broke the large functions into smaller functions, maintaining (one) return per function. reduced many redundancies.
    2- Added docstrings in all functions
    3- used str.format instead of concatentations.
    4- Added rounding to 3 decimal places, added string operations to remove trailing zeros
    5- reduced the amount of filteredElementCollectors in the script. attempted to use query.get_elements_by_class, didn't work for me, I have no idea how to extract objectids from a list without looping.
    6- attempted to use output.insert_divider , no helpful outcome, may I need to look further more into it.
    tay0thman authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    a537784 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2458 from tay0thman/patch-9

    Update radar_check.py
    jmcouffin authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    89db8fd View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Update radar_check.py

    Cleaned up functions,
    Removed redundancy,
    streamlined tabulation of coordinates, distances, and angles.
    used regions to divide functions.
    other formatting items
    tay0thman authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2f3f7ce View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2467 from tay0thman/patch-10

    Update radar_check.py
    jmcouffin authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e4cb829 View commit details
    Browse the repository at this point in the history