Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up unpack_file_url #2535

Merged
merged 1 commit into from
Mar 16, 2015
Merged

Commits on Mar 13, 2015

  1. Speed up unpack_file_url

    E.g.: `pip install /path/to/dir`
    
    by building an sdist and then unpacking it instead of doing
    `shutil.copytree`. `shutil.copytree` may copy files that aren't included
    in the sdist, which means that:
    
    1. If those files are large, a `pip install` could take much longer than
    it should.
    
    2. Folks that are using `python setup.py install` to test their package
    are not fully testing it, because it may copy over files that wouldn't
    be there if they built and sdist and installed that.
    
    So this method building an sdist is both more accurate and faster.
    
    Fixes pypa#2195
    msabramo committed Mar 13, 2015
    1 Configuration menu
    Copy the full SHA
    4e6d935 View commit details
    Browse the repository at this point in the history