Skip to content

Commit

Permalink
tests: session: Remake test_insecure_host into test_trusted_host
Browse files Browse the repository at this point in the history
  • Loading branch information
Noah Gorny committed Mar 23, 2020
1 parent 4632fe3 commit 7f141a2
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions tests/unit/test_network_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,24 @@ def test_http_cache_is_not_enabled(self, tmpdir):

assert not hasattr(session.adapters["http://"], "cache")

def test_insecure_host_adapter(self, tmpdir):
@pytest.mark.parametrize("cache_trusted_hosts", [True, False])
def test_trusted_hosts_adapter(self, tmpdir, cache_trusted_hosts):
session = PipSession(
cache=tmpdir.joinpath("test-cache"),
trusted_hosts=["example.com"],
cache_trusted_hosts=cache_trusted_hosts,
)

assert "https://example.com/" in session.adapters
# Check that the "port wildcard" is present.
assert "https://example.com:" in session.adapters
# Check that the cache isn't enabled.
assert not hasattr(session.adapters["https://example.com/"], "cache")
# Check that the cache is enabled only when
# "cache_trusted_hosts" is enabled.
assert (
cache_trusted_hosts == (
hasattr(session.adapters["https://example.com/"], "cache")
)
)

def test_add_trusted_host(self):
# Leave a gap to test how the ordering is affected.
Expand Down

0 comments on commit 7f141a2

Please sign in to comment.