-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
E.g.: `pip install /path/to/dir` by building an sdist and then unpacking it instead of doing `shutil.copytree`. `shutil.copytree` may copy files that aren't included in the sdist, which means that: 1. If those files are large, a `pip install` could take much longer than it should. 2. Folks that are using `python setup.py install` to test their package are not fully testing it, because it may copy over files that wouldn't be there if they built and sdist and installed that. So this method building an sdist is both more accurate and faster. Fixes #2195
- Loading branch information
Showing
1 changed file
with
42 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6d935
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you forgot to commit the bit that actually calls your new function. Do you still have that lying around anywhere?