Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manylinux_2_34 based on AlmaLinux 9 #1575

Closed
wants to merge 39 commits into from
Closed

Conversation

cyprienc
Copy link

Hi,

I imagine this will require more discussions but I thought I'd at least open an MR proposing a manylinux_2_34 compliant image based on AlmaLinux 9.

I need it to build the nightly wheels of openai/triton which are currently failing because the nvidia and amd backends are now built using more recent versions of stdlibc++ and co.

This relates to triton-lang/triton#2616 and #1574.

Thanks !

@EwoutH
Copy link
Contributor

EwoutH commented Aug 2, 2024

Nice milestone: glibc 2.34 is now supported over 50% of consumer systems using Python.

image

glibc 2.35 is also supported on more than half of the systems, probably since Ubuntu 22.04 has glibc 2.35 bundled by default (and has a huge marketshare).

manylinux_2_34 (AlmaLinux 9 based)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Toolchain: GCC 13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood #1585 (comment) correctly, the request from @mayeut is to use the new GCC 14 toolset for manylinux_2_34.

@mayeut
Copy link
Member

mayeut commented Nov 9, 2024

Thanks for your initial work on this @cyprienc
I'll close this PR and follow-up in #1698

@mayeut mayeut closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants