Support running inside windows self-hosted runner #43
Conversation
…nning inside windows self-hosted runner
action.py
Outdated
There was a problem hiding this comment.
I had encoding issues with emojis, that is why i added that new line for the emojis. I took as reference this post https://stackoverflow.com/questions/3597480/how-to-make-python-3-print-utf8
There was a problem hiding this comment.
Rather than fiddling with sys.stdout.buffer directly, could you try using sys.stdout.reconfigure? For example, calling this once somewhere early in the program should be sufficient:
sys.stdout.reconfigure(encoding='utf-8')...and then we can continue using print as normal everywhere else 🙂
There was a problem hiding this comment.
i have tested a couple of things to avoid the encoding issue but have no luck. I have just tested what you mentioned but got the error again. "UnicodeEncodeError: 'charmap' codec can't encode character '\u274c' in position 0: character maps to <undefined>". Maybe i need to think about something else to try.
There was a problem hiding this comment.
After, testing a little bit more i realized that i was missing encoding="utf-8" where GITHUB_STEP_SUMMARY and GITHUB_OUTPUT were opened. Hopefully, it won't break anything. I updated the code.
action.yml
Outdated
| if [[ "${{runner.os}}" == "Windows" ]]; then | ||
| python "${{ github.action_path }}/action.py" "${{ inputs.inputs }}" | ||
| else | ||
| ${{ github.action_path }}/action.py "${{ inputs.inputs }}" | ||
| fi |
There was a problem hiding this comment.
This Windows form should work well in both cases, so maybe skip the conditional entirely?
| if [[ "${{runner.os}}" == "Windows" ]]; then | |
| python "${{ github.action_path }}/action.py" "${{ inputs.inputs }}" | |
| else | |
| ${{ github.action_path }}/action.py "${{ inputs.inputs }}" | |
| fi | |
| python "${{ github.action_path }}/action.py" "${{ inputs.inputs }}" |
There was a problem hiding this comment.
oh that would be fine then. I just thought about not changing the existing lines to not break anything since i don't have a Linux environment to test.
There was a problem hiding this comment.
I updated the code and left the "python" line.
setup/venv.bash
Outdated
| @@ -17,7 +17,12 @@ fi | |||
| # `python -m pip install ...` invocation might happen to choose. | |||
| if [[ -n "${GHA_PIP_AUDIT_VIRTUAL_ENVIRONMENT}" ]] ; then | |||
| if [[ -d "${GHA_PIP_AUDIT_VIRTUAL_ENVIRONMENT}" ]]; then | |||
| source "${GHA_PIP_AUDIT_VIRTUAL_ENVIRONMENT}/bin/activate" | |||
| if [[ "$OSTYPE" == "msys" || "$(uname)" == MSYS_NT* || "$(uname)" == MINGW* ]]; then | |||
There was a problem hiding this comment.
I think it is coming from Bash. If you think it could break the Linux code i can remove it. Anyways i put two more validations to identify if OS is Windows. It will be ok if i have to remove it.
There was a problem hiding this comment.
I updated the code and removed $OSTYPE.
|
Thanks for opening this, @AngelMF! This is a good initial start; I've left a few comments. |
|
Thanks for the comments @woodruffw. I have added a couple changes. |
|
Merged, thanks again. I'll look into configuring a Windows CI job for this as well, and then do a point release after that. |
|
thanks @woodruffw |
|
Hi, thank you for creating this PR and maintaining this repository! |
|
Hi @hyrodium, thanks for the ping on this. I completely forgot to make a release after this was merged, but I'll look into making one now. |
|
This has been released with v1.1.0! |
|
Thank you very much! The new version v1.1.0 worked fine on my project! |
Add couple lines in action.py, action.yml and venv.bash to support running inside windows self-hosted runner.