Insert -Zbuild-std when building rust packages #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we are linking a copy of the standard library built with some particular version of emscripten selected by the rust compiler that does not match the version we are using. This can lead to an ABI mismatch. See rust-lang/rust#131467
hoodmane
force-pushed
the
rust-build-std
branch
from
e6928ea
to
a84379d
Compare
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Oct 11, 2024
This tests the fix for rust-lang/rust#131467 in pyodide/pyodide-build#40. The problem is that rust cannot correctly read file metadata because the ABI of fstat64 changed between the version of emscripten that the rust compiler built the standard library against and our version of the rust compiler. By passing `-Zbuild-std` we rebuild the rust standard library with the correct abi. I also added a test that works only if we pass `-Zbuild-std`.
|
@juntyr says:
This would have the advantage of not requiring nightly for this feature, but it has the disadvantage that none of the tooling looks very maintained... |
ryanking13
approved these changes
Oct 12, 2024
Comment on lines
+528
to
+530
| elif cmd == "cargo": | ||
| line.insert(1, "-Zbuild-std") | ||
| return line |
There was a problem hiding this comment.
Let's add a test for this (test_pywasmcross.py)
hoodmane
force-pushed
the
rust-build-std
branch
from
5becdcf
to
6377f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we are linking a copy of the standard library built with some particular version of emscripten selected by the rust compiler that does not match the version we are using. This can lead to ABI mismatch.
rust-lang/rust#131467
cc @messense @davidhewitt perhaps it would be good for maturin to also insert this flag when targeting emscripten.