Some minor improvements #2651
Merged
Some minor improvements #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use full path when including MuPDF headers.
…l_dir(). Also minor improvement to listing of wheel contents.
Building tesseract fails because of a known bug in Pyodide, so for now we disable tesseract when building for Pyodide.
Support new environment variables for when building with system MuPDF. Moved classic/rebased extension code into separate functions and moved common setting of build flags into new fn.
If `from . import mupdf` fails, we now also try `import mupdf`. This allows things to work if mupdf module is installed separately, e.g. as part of system installation of MuPDF.
Also extended test_tesseract() to assert that page.get_textpage_ocr() succeeds if TESSDATA_PREFIX is set in environment.
JorjMcKie
approved these changes
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.