Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix include_z when setting stage positions value in PositionTable widget #381

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Nov 6, 2024

fixes #380

for now, this will set the "include z" checkbox to True if any of the positions have a Z position. If only some of them have a z position, it will emit a warning.

If we need the feature in the future, we could further elaborate to somehow let some rows have a Z position of None while others don't

@tlambert03 tlambert03 changed the title fix: fix include_z when setting stage positions value fix: fix include_z when setting stage positions value in PositionTable widget Nov 6, 2024
@tlambert03
Copy link
Member Author

tests are failing, but i think it might be the assertion in the test itself that is no longer correct

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (d58003b) to head (30371b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   90.71%   90.72%           
=======================================
  Files          85       85           
  Lines        9188     9197    +9     
=======================================
+ Hits         8335     8344    +9     
  Misses        853      853           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 7668eda into pymmcore-plus:main Nov 6, 2024
18 checks passed
@tlambert03 tlambert03 deleted the fix-include-z branch November 6, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MDASequence useq widget does not load "include Z" option
1 participant