Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "range" in range-around z-stack widget starts form 0 (no negative numbers) #379

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

fdrgsp
Copy link
Collaborator

@fdrgsp fdrgsp commented Nov 5, 2024

fix for #376: set the minimum possible range for the RANGE_AROUND mode to 0 so we do not have negative values.

closes #376

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (d58003b) to head (69967bd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files          85       85           
  Lines        9188     9188           
=======================================
  Hits         8335     8335           
  Misses        853      853           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdrgsp fdrgsp requested a review from tlambert03 November 6, 2024 13:50
@tlambert03 tlambert03 merged commit e80b7c5 into pymmcore-plus:main Nov 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "range" widget in z-stack widget allows negative numbers
2 participants