Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop support for python 3.8, test 3.12 #368

Merged
merged 15 commits into from
Oct 12, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Oct 4, 2024

this also pins pyside6 to 6.7.3 ... still quite hard to find a good match there

this also stops testing the experimental stack viewer on PySide2/6, since those tests fail too often, and we'll likely move to ndv

@tlambert03 tlambert03 changed the title Drop38 build: drop support for python 3.8 and test up to 3.13 Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.71%. Comparing base (a585acb) to head (ea5130d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mcore_widgets/views/_stack_viewer/_stack_viewer.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.01%     
==========================================
  Files          85       85              
  Lines        9185     9188       +3     
==========================================
+ Hits         8333     8335       +2     
- Misses        852      853       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 changed the title build: drop support for python 3.8 and test up to 3.13 build: drop support for python 3.8 Oct 4, 2024
@tlambert03 tlambert03 changed the title build: drop support for python 3.8 build: drop support for python 3.8, test 3.12 Oct 11, 2024
@tlambert03 tlambert03 merged commit d58003b into pymmcore-plus:main Oct 12, 2024
18 checks passed
@tlambert03 tlambert03 deleted the drop38 branch October 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant